hugovk / heatmap / 36

79%

master: 79%

push

travis-ci

Use a UTC time function

We have a GMT/UTC timestamp.

 * `timegm` expects UTC.
 * `mktime` expects localtime.

Giving a UTC timestamp  to `mktime` can cause OverflowError in edge cases.

For example when in UTC+2 time zones, these cause `OverflowError: mktime argument out of range` with mktime:
 * "1970-01-01T00:00:00 GMT"
 * "1970-01-01T01:59:59 GMT"

And this returns 0.0:
"1970-01-01T02:00:00 GMT"

But with `timegm` those return 0, 7199 and 7200.

3 of 3 new or added lines in 1 file covered. (100.0%)

188 of 673 relevant lines covered (27.93%)

2.22 hits per line