#977
93%

Ran 26 Oct 2022 10:38PM UTC

Jobs 1

Files 73

Run time 3s

Badge

Embed ▾

pending completion

Build # #977

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Add support for boolean constraints (about nullness) in Contract annotations (#669)

For example, the following method will behave equivalently to guava `Preconditions.checkState` with regards to null checks:
```java
@Contract("false -> fail")
static void check(boolean pass) {
  if (!pass) throw new RuntimeException();
}
```

This implementation works in a couple of layers:
- Firstly, contracts with a single boolean resultin in failure are handled by inserting a conditional throw node inline following the annotated method. This provides support for complex boolean logic input validateion.
- Secondly, simple null equal-to and not-equal-to checks are handled by the existing ContractHandler. These don't support such complex inputs, however they are able to work correctly with boolean outputs rather than exclusively `fail` cases.

I've updated the ContractHandler to use more precise language around antecedent nullness, previously null antecedents were described as nullable where cases required null. Please let me know if I've misunderstood the logic, but re-framing the values helped me to understand the logic.

Run Details

5036 of 5431 relevant lines covered (92.73%)

0.93 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
3	92.31	1.4%	../nullaway/src/main/java/com/uber/nullaway/dataflow/cfg/NullAwayCFGBuilder.java
5	96.03	4.1%	../nullaway/src/main/java/com/uber/nullaway/handlers/contract/ContractHandler.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#977.1	26 Oct 2022 10:38PM UTC	73	92.73

uber / NullAway / #977
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #977

uber / NullAway / #977 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #977

uber / NullAway / #977
93%

README BADGES
x