2612
69%

Ran 20 Feb 2014 09:33PM UTC

Jobs 17

Files 354

Run time –

Badge

Embed ▾

pending completion

Build # 2612

Build Type

Pull #958

travis-ci

Committed by

grytysek

Commit Message

wrong access modifiers "private" instead of "protected"

In configuration is parameter:


  <parameter key="doctrine.orm.metadata.xml.class">Doctrine\ORM\Mapping\Driver\SimplifiedXmlDriver</parameter>


that suggest that is designed to override in private bundles but when you try to do that it's nessesary to repeat entire body of methods in own class because of "private" access modifiers, i suggest to change them to 'protected' because it's makes extendig this class more difficult and not clear to understand what is going on inside of this classes.

I suggest to change this modifiers not only in this class...

Pull Request Pull Request #958: wrong access modifiers "private" instead of "protected"

Run Details

14249 of 17292 relevant lines covered (82.4%)

1360.87 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2612.1 (DB=mysql ENABLE_SECOND_LEVEL_CACHE=1)	20 Feb 2014 09:28PM UTC	354	81.83	Travis Job 2612.1
2	2612.2 (DB=pgsql ENABLE_SECOND_LEVEL_CACHE=1)	20 Feb 2014 09:28PM UTC	354	82.06	Travis Job 2612.2
3	2612.3 (DB=sqlite ENABLE_SECOND_LEVEL_CACHE=1)	20 Feb 2014 09:29PM UTC	354	81.25	Travis Job 2612.3
4	2612.4 (DB=mysql ENABLE_SECOND_LEVEL_CACHE=0)	20 Feb 2014 09:28PM UTC	354	81.89	Travis Job 2612.4
5	2612.5 (DB=pgsql ENABLE_SECOND_LEVEL_CACHE=0)	20 Feb 2014 09:27PM UTC	354	82.11	Travis Job 2612.5
6	2612.6 (DB=sqlite ENABLE_SECOND_LEVEL_CACHE=0)	20 Feb 2014 09:38PM UTC	354	81.3	Travis Job 2612.6
7	2612.7 (DB=mysql ENABLE_SECOND_LEVEL_CACHE=1)	20 Feb 2014 09:37PM UTC	354	81.93	Travis Job 2612.7
9	2612.9 (DB=sqlite ENABLE_SECOND_LEVEL_CACHE=1)	20 Feb 2014 09:40PM UTC	354	81.35	Travis Job 2612.9
10	2612.10 (DB=mysql ENABLE_SECOND_LEVEL_CACHE=0)	20 Feb 2014 09:40PM UTC	354	81.99	Travis Job 2612.10
11	2612.11 (DB=pgsql ENABLE_SECOND_LEVEL_CACHE=0)	20 Feb 2014 09:45PM UTC	354	82.22	Travis Job 2612.11
12	2612.12 (DB=sqlite ENABLE_SECOND_LEVEL_CACHE=0)	20 Feb 2014 09:46PM UTC	354	81.41	Travis Job 2612.12
13	2612.13 (DB=mysql ENABLE_SECOND_LEVEL_CACHE=1)	20 Feb 2014 09:47PM UTC	354	81.98	Travis Job 2612.13
14	2612.14 (DB=pgsql ENABLE_SECOND_LEVEL_CACHE=1)	20 Feb 2014 09:47PM UTC	354	82.2	Travis Job 2612.14
15	2612.15 (DB=sqlite ENABLE_SECOND_LEVEL_CACHE=1)	20 Feb 2014 09:49PM UTC	354	81.4	Travis Job 2612.15
16	2612.16 (DB=mysql ENABLE_SECOND_LEVEL_CACHE=0)	20 Feb 2014 09:53PM UTC	354	82.03	Travis Job 2612.16
17	2612.17 (DB=pgsql ENABLE_SECOND_LEVEL_CACHE=0)	20 Feb 2014 09:53PM UTC	354	82.26	Travis Job 2612.17
18	2612.18 (DB=sqlite ENABLE_SECOND_LEVEL_CACHE=0)	20 Feb 2014 09:55PM UTC	354	81.45	Travis Job 2612.18

Source Files on build 2612

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

doctrine / doctrine2 / 2612
69%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2612

doctrine / doctrine2 / 2612 69%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2612

doctrine / doctrine2 / 2612
69%

README BADGES
x