109
100%

Ran 04 Mar 2016 05:45AM UTC

Jobs 8

Files 1

Run time 2min

Badge

Embed ▾

pending completion

Build # 109

Build Type

push

travis-ci

Committed by

oconnor663

Commit Message

get rid of STRING and BYTES in favor of PIPE

I think it will be fairly common for people to want to `read()` stdout
as bytes. Requiring callers to `from duct import BYTES` feels
unnecessarily awkward. Setting `decode=False` is much easier, and it
avoids the confusing state where one output is decoded and the other
isn't.

There's a chance that `PIPE` itself will feel too close to `pipe()` for
comfort, given that it means something very different. I might want to
bikeshed that some more in the future. (Maybe simpler flags like
`capture_stdout` and `capture_stderr`? Though it would be a little weird
to have those and also `stdout`/stderr`.) But in any case `PIPE` is the
Python convention, and it's a reasonable first improvement.

While we're at it, rename `trim` to `sh_trim`. That's more suggestive of
what it's actually doing, especially with an eye towards languages (like
Rust) that use `trim` to mean what `strip` means in Python.

Closes https://github.com/oconnor663/duct/issues/32.

Run Details

338 of 342 relevant lines covered (98.83%)

7.83 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	109.1	04 Mar 2016 05:45AM UTC	98.25	Travis Job 109.1
2	109.2	04 Mar 2016 05:45AM UTC	98.25	Travis Job 109.2
3	109.3	04 Mar 2016 05:45AM UTC	97.66	Travis Job 109.3
4	109.4	04 Mar 2016 05:46AM UTC	97.37	Travis Job 109.4
5	109.5	04 Mar 2016 05:46AM UTC	97.37	Travis Job 109.5
6	109.6	04 Mar 2016 05:47AM UTC	98.25	Travis Job 109.6
7	109.7	04 Mar 2016 05:46AM UTC	98.25	Travis Job 109.7
8	109.8	04 Mar 2016 05:46AM UTC	97.37	Travis Job 109.8

Source Files on build 109

Detailed source file information is not available for this build.

oconnor663 / duct / 109
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 109

oconnor663 / duct / 109 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 109

oconnor663 / duct / 109
100%

README BADGES
x