STEllAR-GROUP / hpx / #800

83%

push

<a href="https://github.com/STEllAR-GROUP/hpx/commit/<a class=hub.com/STEllAR-GROUP/hpx/commit/2813888d50d38b04f0daa48f0c764e23029eed64">2813888d5<a href="https://github.com/STEllAR-GROUP/hpx/commit/2813888d50d38b04f0daa48f0c764e23029eed64">&quot;&gt;Merge #6026

6026: add option hpx:force_ipv4 to force resolving hostnames to ipv4 adresses r=hkaiser a=Neumann-A

## Proposed Changes

  - add an option to force resolving hostnames to ipv4 adresses

## Any background context you want to provide?

Local hostnames on windows are commonly resolved to ipv6 addresses while remote hostnames resolved to ipv4 addresses. This leads to hpx applications to listen on the wrong addresses if using hostnames on windows. 

The following code might also be related to this since pinging localhost returns a ipv6 `::1` instead of ipv4. 

https://github.com/STEllAR-GROUP/hpx/blob/</a><a class="double-link" href="https://github.com/STEllAR-GROUP/hpx/commit/<a class="double-link" href="https://github.com/STEllAR-GROUP/hpx/commit/435ae68f04084df3fa652ef76571b78db1980e8d">435ae68f0</a>">435ae68f0</a><a href="https://github.com/STEllAR-GROUP/hpx/commit/2813888d50d38b04f0daa48f0c764e23029eed64">/libs/core/asio/src/map_hostnames.cpp#L26-L36

## Checklist

Not all points below apply to all pull requests.

- [x] I have added a new feature ~~and have added tests to go along with it.~~ (I don&#39;t even see where to add a test here;somewhere in CI?)
- [ ] ~~I have fixed a bug and have added a regression test~~.
- [ ] ~~I have added a test using random numbers; I have made sure it uses a seed, and that random numbers generated are valid inputs for the tests~~.

## Other comment.

Maybe HPX should detect ipv4/ipv6 mismatch on its own since it has to lookup the endpoints any way?


Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>

14 of 14 new or added lines in 4 files covered. (100.0%)

170863 of 198196 relevant lines covered (86.21%)

1983026.47 hits per line