3114504430

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/kobotoolbox/kpi/commit/<a class=hub.com/kobotoolbox/kpi/commit/12eb30567d9e78172908aee59ee5c55cb1d591a3">12eb30567<a href="https://github.com/kobotoolbox/kpi/commit/12eb30567d9e78172908aee59ee5c55cb1d591a3">">Merge </a><a class="double-link" href="https://github.com/kobotoolbox/kpi/commit/<a class="double-link" href="https://github.com/kobotoolbox/kpi/commit/559b48da5ef2a26c4f6526fcc5059e17964e28e1">559b48da5</a>">559b48da5</a><a href="https://github.com/kobotoolbox/kpi/commit/12eb30567d9e78172908aee59ee5c55cb1d591a3"> into 5aa18ef23">5aa18ef23</a>

Pull Request Pull Request #4002: Async NLP transcript and refactor gcloud and speech interaction

Run Details

2875 of 4496 branches covered (63.95%)

99 of 99 new or added lines in 9 files covered. (100.0%)

10399 of 13720 relevant lines covered (75.79%)

0.76 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

77.03

/kobo/apps/subsequences/api_view.py

import json

from jsonschema import validate
from jsonschema.exceptions import ValidationError as SchemaValidationError
from kobo.apps.subsequences.models import SubmissionExtras
from kpi.models import Asset
from kpi.permissions import SubmissionPermission
from kpi.views.environment import _check_asr_mt_access_for_user
from rest_framework.exceptions import PermissionDenied
from rest_framework.exceptions import ValidationError as APIValidationError
from rest_framework.response import Response
from rest_framework.views import APIView


def _check_asr_mt_access_if_applicable(user, posted_data):
    # This is for proof-of-concept testing and will be replaced with proper
    # quotas and accounting
    MAGIC_STATUS_VALUE = 'requested'
    user_has_access = _check_asr_mt_access_for_user(user)
    if user_has_access:
        return True
    # Oops, no access. But did they request ASR/MT in the first place?
    for _, val in posted_data.items():
        # e.g.
        # {
        #   "submission": "8b6c1fba-c9ef-477b-bfc0-873aa8bfd73f",
        #   "record_speech": {
        #     "googlets": {
        #       "status": "requested",
        #       "languageCode": "en"
        #     }
        #   }
        # }
        if not isinstance(val, dict):
            continue
        for _, child_val in val.items():
            if not isinstance(child_val, dict):
                continue
            try:
                asr_mt_request = child_val['status'] == MAGIC_STATUS_VALUE
            except KeyError:
                continue
            else:
                if asr_mt_request:
                    # This is temporary code, and anyone here is trying to
                    # abuse the API, so don't bother translators with the
                    # message string
                    raise PermissionDenied('ASR/MT features are not available')


class AdvancedSubmissionView(APIView):
    permission_classes = [SubmissionPermission]
    queryset = Asset.objects.all()
    asset = None

    def initial(self, request, asset_uid, *args, **kwargs):
        # This must be done first in order to work with SubmissionPermission
        # which typically expects to be a nested view under Asset
        self.asset = self.get_object(asset_uid)
        return super().initial(request, asset_uid, *args, **kwargs)

    def get_object(self, uid):
        asset = self.queryset.get(uid=uid)
        self.check_object_permissions(self.request, asset)
        return asset

    def get(self, request, asset_uid, format=None):
        if 'submission' in request.data:
            s_uuid = request.data.get('submission')
        else:
            s_uuid = request.query_params.get('submission')
        return get_submission_processing(self.asset, s_uuid)

    def post(self, request, asset_uid, format=None):
        posted_data = request.data
        schema = self.asset.get_advanced_submission_schema()
        try:
            validate(posted_data, schema)
        except SchemaValidationError as err:
            raise APIValidationError({'error': err})

        _check_asr_mt_access_if_applicable(request.user, posted_data)

        submission = self.asset.update_submission_extra(posted_data)
        return Response(submission.content)


def get_submission_processing(asset, s_uuid):
    try:
        submission = asset.submission_extras.get(submission_uuid=s_uuid)
        return Response(submission.content)
    except SubmissionExtras.DoesNotExist:
        # submission might exist but no SubmissionExtras object has been created
        return Response({'info': f'nothing found for submission: {s_uuid}'})

1	import json	2✔
2
3	from jsonschema import validate	2✔
4	from jsonschema.exceptions import ValidationError as SchemaValidationError	2✔
5	from kobo.apps.subsequences.models import SubmissionExtras	2✔
6	from kpi.models import Asset	2✔
7	from kpi.permissions import SubmissionPermission	2✔
8	from kpi.views.environment import _check_asr_mt_access_for_user	2✔
9	from rest_framework.exceptions import PermissionDenied	2✔
10	from rest_framework.exceptions import ValidationError as APIValidationError	2✔
11	from rest_framework.response import Response	2✔
12	from rest_framework.views import APIView	2✔
13
14
15	def _check_asr_mt_access_if_applicable(user, posted_data):	2✔
16	# This is for proof-of-concept testing and will be replaced with proper
17	# quotas and accounting
18	MAGIC_STATUS_VALUE = 'requested'	2✔
19	user_has_access = _check_asr_mt_access_for_user(user)	2✔
20	if user_has_access:	2✔
21	return True	2✔
22	# Oops, no access. But did they request ASR/MT in the first place?
23	for _, val in posted_data.items():	2✔
24	# e.g.
25	# {
26	# "submission": "8b6c1fba-c9ef-477b-bfc0-873aa8bfd73f",
27	# "record_speech": {
28	# "googlets": {
29	# "status": "requested",
30	# "languageCode": "en"
31	# }
32	# }
33	# }
34	if not isinstance(val, dict):	2✔
35	continue	2✔
36	for _, child_val in val.items():	2✔
37	if not isinstance(child_val, dict):	2!
38	continue	×
39	try:	2✔
40	asr_mt_request = child_val['status'] == MAGIC_STATUS_VALUE	2✔
41	except KeyError:	2✔
42	continue	2✔
43	else:
44	if asr_mt_request:	×
45	# This is temporary code, and anyone here is trying to
46	# abuse the API, so don't bother translators with the
47	# message string
48	raise PermissionDenied('ASR/MT features are not available')	×
49
50
51	class AdvancedSubmissionView(APIView):	2✔
52	permission_classes = [SubmissionPermission]	2✔
53	queryset = Asset.objects.all()	2✔
54	asset = None	2✔
55
56	def initial(self, request, asset_uid, args, *kwargs):	2✔
57	# This must be done first in order to work with SubmissionPermission
58	# which typically expects to be a nested view under Asset
59	self.asset = self.get_object(asset_uid)	2✔
60	return super().initial(request, asset_uid, args, *kwargs)	2✔
61
62	def get_object(self, uid):	2✔
63	asset = self.queryset.get(uid=uid)	2✔
64	self.check_object_permissions(self.request, asset)	2✔
65	return asset	2✔
66
67	def get(self, request, asset_uid, format=None):	2✔
68	if 'submission' in request.data:	×
69	s_uuid = request.data.get('submission')	×
70	else:
71	s_uuid = request.query_params.get('submission')	×
72	return get_submission_processing(self.asset, s_uuid)	×
73
74	def post(self, request, asset_uid, format=None):	2✔
75	posted_data = request.data	2✔
76	schema = self.asset.get_advanced_submission_schema()	2✔
77	try:	2✔
78	validate(posted_data, schema)	2✔
79	except SchemaValidationError as err:	2✔
80	raise APIValidationError({'error': err})	2✔
81
82	_check_asr_mt_access_if_applicable(request.user, posted_data)	2✔
83
84	submission = self.asset.update_submission_extra(posted_data)	2✔
85	return Response(submission.content)	2✔
86
87
88	def get_submission_processing(asset, s_uuid):	2✔
89	try:	×
90	submission = asset.submission_extras.get(submission_uuid=s_uuid)	×
91	return Response(submission.content)	×
92	except SubmissionExtras.DoesNotExist:	×
93	# submission might exist but no SubmissionExtras object has been created
94	return Response({'info': f'nothing found for submission: {s_uuid}'})	×

kobotoolbox / kpi / 3114504430

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous