1082
88%

Ran 29 Feb 2016 10:38PM UTC

Jobs 4

Files 40

Run time 2min

Badge

Embed ▾

pending completion

Build # 1082

Build Type

Pull #234

travis-ci

Committed by

prashantv

Commit Message

Fix bug causing TestCloseSingleChannel to fail

There was a very subtle bug when a connection is closed right after a
successful call is received.
recvPeerFrame was blocked in select {recvCh, errCh}. When a connection
reads a frame, puts it into the recvCh, but then gets an EOF and puts
an EOF error in the errCh, the select will randomly choose a case.
There is no priority order.

In our case, we want a strict priority order when reading frames to
always choose recvCh if there's any frames, and process errors after.
Emulate a priority order by checking recvCh in the errCh case using
a non-blocking select (both on the writer and reader side).

Pull Request Pull Request #234: Unblock calls on connection errors or if the stream has ended

Run Details

3069 of 3764 relevant lines covered (81.54%)

6885.5 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1082.1	29 Feb 2016 10:38PM UTC	80.79	Travis Job 1082.1
2	1082.2	29 Feb 2016 10:38PM UTC	81.12	Travis Job 1082.2
3	1082.3	29 Feb 2016 10:38PM UTC	80.8	Travis Job 1082.3
4	1082.4	29 Feb 2016 10:40PM UTC	81.2	Travis Job 1082.4

Source Files on build 1082

Detailed source file information is not available for this build.

uber / tchannel-go / 1082
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1082

uber / tchannel-go / 1082 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1082

uber / tchannel-go / 1082
88%

README BADGES
x