#959
93%

Ran 14 Sep 2022 12:03AM UTC

Jobs 1

Files 73

Run time 3s

Badge

Embed ▾

pending completion

Build # #959

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Prevent crash in fixserialization when ClassSymbol.sourcefile is null. (#656)

In general, neither `ClassSymbol.sourcefile` nor `ClassSymbol.classfile` are guaranteed to be non-null. This can lead to crashes when performing fixserialization, in particular when the symbol comes from a jar file.

This PR changes our logic to provide best effort file locations for code, checking first for `sourcefile`, then `classfile`, then defaulting to the string `"null"`. 

We also add a test case to simulate the behavior of other build systems (namely buck) where `sourcefile` might be `null`. This requires adding significant new mockito magic to our tests, including `mockito-inline`.

Run Details

4929 of 5326 relevant lines covered (92.55%)

0.93 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	#959.1	14 Sep 2022 12:03AM UTC	73	92.55

uber / NullAway / #959
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #959

uber / NullAway / #959 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #959

uber / NullAway / #959
93%

README BADGES
x