#918
93%

Ran 30 Aug 2022 10:47PM UTC

Jobs 1

Files 73

Run time 7s

Badge

Embed ▾

pending completion

Build # #918

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Generalize handler APIs for return nullability on (un-)annotated code (#641)

This is a follow up to changes in #639, #636, and #624. Here we
generalize the former Handler callback:

- onUnannotatedInvocationGetExplicitlyNonNullReturn

which was used to change the nullability of method returns in
unannotated code for the purpose of method `@Override` checks
(i.e. subtyping).
    
We provide instead:
    
- onOverrideMethodInvocationReturnNullability
    
Which allows handlers to change the nullability of method
returns for both annotated and unannotated code, for the same
purposes.
    
Additionally, we implement this new handler callback in
`LibraryModelsHandler`.
    
Before this change, marking a return as non-null in a library model
affected checking of method invocations, but not necessarily
overriding/subtyping checks.

Run Details

4863 of 5252 relevant lines covered (92.59%)

0.93 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	91.67	0.0%	../nullaway/src/main/java/com/uber/nullaway/handlers/Handler.java
3	99.41	0.0%	../nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java
25	95.5	0.04%	../nullaway/src/main/java/com/uber/nullaway/NullAway.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#918.1	30 Aug 2022 10:48PM UTC	73	92.59

uber / NullAway / #918
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #918

uber / NullAway / #918 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #918

uber / NullAway / #918
93%

README BADGES
x