hypothesis / h / 10539

69%

master: 97%

push

travis-ci

Ensure request session is correctly committed in non-web contexts

f0c96f2 changed the relationship between the transaction manager and the
SQLAlchemy session so that it became possible to fetch a session that
wasn't managed by the transaction manager. (This is useful for the
websocket server, which manages its own database session.)

Unfortunately, this introduced a rather unpleasant bug, whereby if
during the course of a request nobody accessed the session as
`request.db` (using the base model `query` property exclusively, for
example) then the session would never get tied to the transaction
manager and would be dropped when the request ended.

This commit fixes that by moving the code that registers the session
with the transaction manager into a NewRequest subscriber, which ensures
that it happens on every request. This has the downside of requiring a
session be constructed for every request, but there's no easy way around
this while we use the magic session query property.

Pyramid doesn't run NewRequest subscribers when creating a request
manually using `Request.blank` as we currently do in `h.script` and
`h.worker`, so these environments must manually commit the open database
transaction.

11 of 11 new or added lines in 3 files covered. (100.0%)

2816 of 4060 relevant lines covered (69.36%)

0.69 hits per line