5669
83%
master: 93%

Ran 24 Feb 2016 01:11AM UTC

Jobs 7

Files 141

Run time 6min

Badge

Embed ▾

pending completion

Build # 5669

Build Type

push

travis-ci

Committed by

keradus

Commit Message

bug #1776 EofEndingFixer - new line on end line comment is allowed (Slamdunk)

This PR was submitted for the 1.12 branch but it was merged into the 1.11 branch instead (closes #1776).

Discussion
----------

EofEndingFixer - new line on end line comment is allowed

The new line of a comment in the last line is indeed a new line and no other new lines should be attached.

As of yet, this code (I will expand line-feeds):
```php
<?php[\n]
return true;[\n]
// Comment[\n]
```
is fixed like
```php
<?php[\n]
return true;[\n]
// Comment[\n]
[\n]
```
Which breaks the statement of the fixer:
`A file must always end with a single empty line feed.`
and also the Unix file management.

Commits
-------

a249688 EofEndingFixer - new line on end line comment is allowed

Run Details

4512 of 5392 relevant lines covered (83.68%)

412.86 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5669.1 (COMPOSER_FLAGS="--prefer-stable --prefer-lowest")	24 Feb 2016 01:07AM UTC	141	79.03	Travis Job 5669.1
2	5669.2	24 Feb 2016 01:10AM UTC	141	86.1	Travis Job 5669.2
3	5669.3	24 Feb 2016 01:12AM UTC	141	86.27	Travis Job 5669.3
4	5669.4 (SYMFONY_VERSION="~2.7")	24 Feb 2016 01:12AM UTC	141	86.47	Travis Job 5669.4
5	5669.5 (SYMFONY_VERSION="~3.0@dev" COMPOSER_FLAGS="--prefer-stable")	24 Feb 2016 01:12AM UTC	141	86.47	Travis Job 5669.5
6	5669.6	24 Feb 2016 01:12AM UTC	141	90.13	Travis Job 5669.6
7	5669.7	24 Feb 2016 01:15AM UTC	141	78.72	Travis Job 5669.7

Source Files on build 5669

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

FriendsOfPHP / PHP-CS-Fixer / 5669
83%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5669

FriendsOfPHP / PHP-CS-Fixer / 5669 83% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5669

FriendsOfPHP / PHP-CS-Fixer / 5669
83%
master: 93%

README BADGES
x