902
95%

Ran 23 Feb 2016 07:03AM UTC

Jobs 1

Files 38

Run time 1s

Badge

Embed ▾

pending completion

Build # 902

Build Type

Pull #112

travis-ci

Committed by

Motiejus

Commit Message

Fix race in membership and ring consistency

Without this change, membership and ring could be not in sync. Scenario:
A - current node.
B - alive (according to C).
B - suspect (according to D).
C - thinks B is faulty.
D - thinks B is alive.

At the same time:
1. C gossips A that B is faulty. A removes B to the membership list.
2. D gossips A that B is alive. A adds B from the membership list.

Changes in the ring:
3. The lock on m.members is released, so updates on Ring due to (1) and
   (2) can execute in any order. In our example, the operations are
   reversed:
3.1. A adds B to the ring list due to (2).
3.2. A removes B to the ring list due to (1).

Now B is in the membership list, but not in the ring.

This is the second iteration of the change. First iteration did not
introduce a new lock, but a new invariant: a goroutine needs to lock
both memberlist and disseminator, lock memberlist first, then
disseminator. However, the invariant caused requestAdminStats to fail on
travis-ci, and I couldn't find out why.

Pull Request Pull Request #112: Fix race in membership and ring consistency

Run Details

3545 of 3816 relevant lines covered (92.9%)

0.93 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
4	902.4 (RUN=test/update-coveralls)	23 Feb 2016 07:03AM UTC	38	92.9	Travis Job 902.4

Source Files on build 902

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

uber / ringpop-go / 902
95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 902

uber / ringpop-go / 902 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 902

uber / ringpop-go / 902
95%

README BADGES
x