Valloric / ycmd / 1558
94%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 42
Run time 3s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1558

push

travis-ci

homu 
Auto merge of #376 - Valloric:headers-fix, r=puremourning

[READY] Fixing issues with setting headers on py2

Bottle is dumb when it comes to headers and bytes vs unicode. Details in source comments.

Funny thing: the reason why I didn't notice this problem while working on the py3 compatibility PR is that all our tests skip the main WSGI interface, so to test that part too since we don't have ycmd smoke tests (yet, but I'll be fixing that), I used the example_client to talk to ycmd. This worked great, but since the example_client only works on py3, I only tested in a py3 pyenv, which ran ycmd in a py3 interpreter... but this problem only appears on a py2 interpreter, which I'm using now while trying to make YCM work with latest ycmd.

Yet another case of "having more tests would have caught this early and saved you a ton of effort and hair-pulling" (which I'm naming _The Perennial Lesson_ AKA _MOAR TESTS!_). Here we needed ycmd smoke tests that bring up the whole server (on both pythons) and send a `/healthy` ping. It would have caught this.

Second funny thing: I was literally working on such smoke tests this morning before I realized it will be a lot of work and decided to work on something else (YCM with latest ycmd) instead. Serves me right.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/376)
<!-- Reviewable:end -->

2963 of 3513 relevant lines covered (84.34%)

0.84 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1558.1 (USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true) 0
84.34
 Travis Job 1558.1
Source Files on build 1558
Detailed source file information is not available for this build.