#890
93%

Ran 14 Jul 2022 08:02PM UTC

Jobs 1

Files 73

Run time 12s

Badge

Embed ▾

pending completion

Build # #890

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Remove nullable annotation configuration in fix serialization. (#621)

Following GH-517 If `serializeFixMetadata` is active, `NullAway` will serialize suggested type changes (currently just adding `@Nullable`). In the `FixSerializationConfig` file we can set a custom annotation that `NullAway` will use in the output serializations. 

However, this process can be simplified by just asking `NullAway` to serialize type change locations with a default annotation name, any tool processing this output can use their own preferred annotation.

After this PR the following entity will be removed from the config `.xml` file:
```xml
<annotation>
       <nonnull> ... </nonnull>
       <nullable> ... </nullable>
</annotation
```
And a sample out below:
```
Field bar of Foo, ASSIGN_FIELD_NULLABLE, @Nullable
```

Will be changed to simply:
```
Field bar of Foo, ASSIGN_FIELD_NULLABLE, nullable
```

Run Details

4787 of 5178 relevant lines covered (92.45%)

0.92 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	80.77	-0.71%	../nullaway/src/main/java/com/uber/nullaway/fixserialization/SerializationService.java
4	92.98	-1.38%	../nullaway/src/main/java/com/uber/nullaway/fixserialization/FixSerializationConfig.java
6	79.17	0.0%	../nullaway/src/main/java/com/uber/nullaway/fixserialization/Serializer.java
6	74.14	-3.13%	../nullaway/src/main/java/com/uber/nullaway/fixserialization/XMLUtil.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#890.1	14 Jul 2022 08:02PM UTC	73	92.45

uber / NullAway / #890
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #890

uber / NullAway / #890 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #890

uber / NullAway / #890
93%

README BADGES
x