2618470269

Build Type

github

Committed by GitHub

Commit Message

<a href="https://github.com/kobotoolbox/kpi/commit/<a class=hub.com/kobotoolbox/kpi/commit/<a class="double-link" href="https://git"><a class=hub.com/kobotoolbox/kpi/commit/<a class="double-link" href="https://git"><a class=hub.com/kobotoolbox/kpi/commit/<a class="double-link" href="https://git"><a class=hub.com/kobotoolbox/kpi/commit/55cfea83a16745279d623bf948a610f850387972">55cfea83a">&lt;a href=&quot;https://github.com/kobotoolbox/kpi/commit/</a><a class="double-link" href="https://github.com/kobotoolbox/kpi/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/kobotoolbox/kpi/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/kobotoolbox/kpi/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/kobotoolbox/kpi/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/kobotoolbox/kpi/commit/55cfea83a16745279d623bf948a610f850387972">55cfea83a</a><a href="https://github.com/kobotoolbox/kpi/commit/55cfea83a16745279d623bf948a610f850387972">&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/kobotoolbox/kpi/commit/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/kobotoolbox/kpi/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/kobotoolbox/kpi/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/kobotoolbox/kpi/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/kobotoolbox/kpi/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=&lt;/a&gt;hub.com/kobotoolbox/kpi/commit/55cfea83a16745279d623bf948a610f850387972&quot;&gt;55cfea83a&lt;/a&gt;&lt;a href=&quot;https://github.com/kobotoolbox/kpi/commit/55cfea83a16745279d623bf948a610f850387972&quot;&gt;&amp;quot;&amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/kobotoolbox/kpi/commit/&amp;lt;/a&amp;gt;&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://github.com/kobotoolbox/kpi/commit/&amp;amp;lt;a class=&amp;amp;quot;double-link&am... (continued)

Pull Request Pull Request #3918: Consistent usage of Mfa acronym in the code base

Run Details

2627 of 4031 branches covered (65.17%)

27 of 27 new or added lines in 10 files covered. (100.0%)

9225 of 12138 relevant lines covered (76.0%)

0.76 hits per line

Source File
Press 'n' to go to next uncovered line, 'b' for previous

83.33

/kobo/apps/mfa/signals.py

# coding: utf-8
from django.db.models.signals import pre_delete
from django.dispatch import receiver

from .models import MfaAvailableToUser, MfaMethod


@receiver(pre_delete, sender=MfaAvailableToUser)
def deactivate_mfa_method_for_user(**kwargs):
    """
    Deactivate MFA methods for user on delete (and bulk delete)
    """
    # We need to use a signal (instead of adding this code to
    # `MfaAvailableToUser.delete()`) because of bulk deletes which do not
    # call `.delete()`.

    mfa_available_to_user = kwargs['instance']
    # Deactivate any MFA methods user could have already created
    try:
        # Use `.get()` + `.save()` (from model `MfaMethod`) instead of
        # `.update()` to run some logic inside `.save()`. It makes an extra
        # query to DB but avoid duplicated code.
        mfa_method = MfaMethod.objects.get(user=mfa_available_to_user.user)
    except MfaMethod.DoesNotExist:
        pass
    else:
        mfa_method.is_active = False
        mfa_method.save(update_fields=['is_active'])

1	# coding: utf-8
2	from django.db.models.signals import pre_delete	2✔
3	from django.dispatch import receiver	2✔
4
5	from .models import MfaAvailableToUser, MfaMethod	2✔
6
7
8	@receiver(pre_delete, sender=MfaAvailableToUser)	2✔
9	def deactivate_mfa_method_for_user(**kwargs):	2✔
10	"""
11	Deactivate MFA methods for user on delete (and bulk delete)
12	"""
13	# We need to use a signal (instead of adding this code to
14	# `MfaAvailableToUser.delete()`) because of bulk deletes which do not
15	# call `.delete()`.
16
17	mfa_available_to_user = kwargs['instance']	2✔
18	# Deactivate any MFA methods user could have already created
19	try:	2✔
20	# Use `.get()` + `.save()` (from model `MfaMethod`) instead of
21	# `.update()` to run some logic inside `.save()`. It makes an extra
22	# query to DB but avoid duplicated code.
23	mfa_method = MfaMethod.objects.get(user=mfa_available_to_user.user)	2✔
24	except MfaMethod.DoesNotExist:	×
25	pass	×
26	else:
27	mfa_method.is_active = False	2✔
28	mfa_method.save(update_fields=['is_active'])	2✔

kobotoolbox / kpi / 2618470269

Source File Press 'n' to go to next uncovered line, 'b' for previous

Source File
Press 'n' to go to next uncovered line, 'b' for previous