#881
93%

Ran 21 Jun 2022 10:35PM UTC

Jobs 1

Files 75

Run time 170min

Badge

Embed ▾

pending completion

Build # #881

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Treat Void formal arguments as @Nullable (#613)

This is a follow up on #595. See that PR for some of the soundness
caveats related to method overriding and the nullability of Void
in our current implementation.

This does, however, avoid some otherwise awkward suppressions,
as shown in #608.

There are two correct ways of handling Void:

a) Having it default to `@Nullable` as a type, which requires us
   adding a "default nullability" for some types/classes and explicitly
   contradicts JSpecify (jspecify/jspecify#51)
b) Supporting generics, and requiring explicitly annotating `@Nullable Void`.
   This will probably also require third-party libraries which we consider
   annotated (such as CF), to adopt this convention.

I believe (b) is the way forward long-term, which means that, for now,
this hack might be the best we can do without generics support. Once
NullAway supports generics, both this change and #595 should be reverted.

Run Details

4824 of 5213 relevant lines covered (92.54%)

0.93 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
2	95.74	-1.06%	../nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPath.java
3	90.91	-0.52%	../nullaway/src/main/java/com/uber/nullaway/dataflow/cfg/NullAwayCFGBuilder.java
14	95.28	0.01%	../nullaway/src/main/java/com/uber/nullaway/NullAway.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#881.1	21 Jun 2022 10:35PM UTC	75	92.54

uber / NullAway / #881
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #881

uber / NullAway / #881 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #881

uber / NullAway / #881
93%

README BADGES
x