• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

ICRAR / daliuge / 2325
81%
master: 81%

Build:
Build:
LAST BUILD BRANCH: LIU-401
DEFAULT BRANCH: master
Ran 03 Jun 2022 07:50AM UTC
Jobs 1
Files 37
Run time 5s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2325

push

travis-ci-com

rtobar
Correctly calculate roots of PG before submission

The removal of the last node in the PG seems to correspond to the logic
of that last node having the reproducibility data of the graph instead
of an actual drop specification. This reproducibility data is optional
though, and therefore the "dlg submit" tool, via this submit() function,
was broken and removed the last drop specification from the calculation
of the graph roots, which in turn had the effect that the session didn't
trigger one of the roots of the graph at graph submission time, leaving
the graph in Running state forever.

This change fixes the submission of "normal" graphs (i.e., without the
extra reproducibility data object at the end), making the tool usable
for existing graphs. This will clearly break graphs *with* the
reproducibility data, but those are still fewer in number.

I found this problem while working on YAN-999.

Signed-off-by: Rodrigo Tobar <rtobar@icrar.org>

3595 of 5617 relevant lines covered (64.0%)

0.64 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2325.1 (NO_DLG_RUNTIME=1) 03 Jun 2022 07:50AM UTC 0
64.0
Travis Job 2325.1
Source Files on build 2325
Detailed source file information is not available for this build.
  • Back to Repo
  • Build #2325
  • 39604903 on github
  • Next Build on fix-dlg-submit (#2326)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc