#3086
100%
master: 100%

Ran 25 May 2022 05:03AM UTC

Jobs 1

Files 77

Run time 23s

Badge

Embed ▾

pending completion

Build # #3086

Build Type

push

github-actions

Committed by

ben-manes

Commit Message

Less aggressive discard on conflict for  AsyncCache's refreshes (fixes #714)

Linearization means that the refresh should be dropped if another write
for that entry occurs, as we may populate the cache with stale data. The
cache uses a write timestamp to help detect this. However, when this
could be too aggressive when a refresh runs concurrently with the async
load completing.

An inflight load is given an infinite timestamp so that it never expires.
A whenComplete callback then updates the entry with its policy metadata,
such as its expiration time. That changes the write timestamp and if a
refresh runs concurrently with the callback then the refresh may see the
infinite timestamp, the replace updates it, and the refresh drops the
entry as a conflict.

Instead we can detect this case by seeing if the timestamp delta exceeds
our maximum value (120yrs). IF so, then we know this race occurred and
can trust the update. Of course intermediate writes might still have
occurred, so we have to check that our refresh future was sucessfully
unregistered, which would have been discarded in had any other write
occurred.

Run Details

7086 of 7212 relevant lines covered (98.25%)

0.98 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	#3086.1	25 May 2022 05:03AM UTC	0	98.25

Source Files on build #3086

Detailed source file information is not available for this build.

ben-manes / caffeine / #3086
100%
master: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #3086

ben-manes / caffeine / #3086 100% master: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #3086

ben-manes / caffeine / #3086
100%
master: 100%

README BADGES
x