m-lab / pusher / 461

99%

main: 99%

push

travis-ci-com

Removes old, empty directories from datatype root directories (#99)

* Removes old, empty directories

Pusher did not remove old directories. Every extant directory creates an
inotify watch in pusher. Over time and/or for experiments (e.g., wehe)
that create a large amount of directories, this can create a very large
number of useless watches, which eat up memory, and eventually may run
up against fs.inotify.max_user_watches, causing other containers on the
system to fail.

This commit also fixes an apparent variable name bug in which the value
for maxFileAge was put into a variable named minFileAge.

* Removes old, empty directories when walking dir

Previously, directories were not touched. On long-running containers
directories would begin to pile up causing a large amount of useless
pusher inotify directories watches.

* Uses Go v1.18 to build Docker image, and Alpine 3.15

* Updates Go modules

* Reverts prometheus/client_golang to v1.11.0

I was running into this with newer versions:

https://github.com/prometheus/prometheus/issues/10574

* Updates Travis to use Go v1.18

* Reverts Go to v1.17 (from v1.18)

The travis build was failing with something like this:

https://github.com/mattn/goveralls/issues/207

... and the Docker build was failing with this error:

Step 8/10 : COPY --from=build /go/bin/pusher /
COPY failed: stat go/bin/pusher: file does not exist

* Adds a clarifying comment about removing dirs

* Simplifies dir removal logic, removes branching

36 of 36 new or added lines in 1 file covered. (100.0%)

549 of 555 relevant lines covered (98.92%)

11672.22 hits per line