533
99%

Ran 28 Jan 2016 04:08AM UTC

Jobs 4

Files 2

Run time 6s

Badge

Embed ▾

pending completion

Build # 533

Build Type

push

travis-ci

Committed by

chriso

Commit Message

Fix a timezone issue in isDate()

The validator accepts ISO 8601 dates which include "%Y-%m-%d" and
"%Y-%m-%d %H:%M". The validator makes use of Date.parse() to parse
the date before checking if the date is invalid (e.g. 2015-02-29).
The built-in Date.parse() function interprets "%Y-%m-%d" dates in
GMT but "%Y-%m-%d %H:%M" in the user's timezone. This caused the
validator to apply an incorrect timezone offset which then caused
it to get out of sync with the built-in Date.parse() function.
Because of this mismatch, certain dates such as 2011-12-21 were
being marked as invalid when the user had a timezone offset < 0,
e.g. in PST, since the date would become 2011-12-20 after the
incorrect timezone offset was applied.

This fixes the function that determines the timezone in the date.
It now checks for the special "%Y-%m-%d" case and returns a
timezone offset of 0 (GMT).

cc #480

Coverage Stats

468 of 478 relevant lines covered (97.91%)

512.05 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	533.1	28 Jan 2016 04:08AM UTC	97.91	Travis Job 533.1
2	533.2	28 Jan 2016 04:08AM UTC	97.91	Travis Job 533.2
3	533.3	28 Jan 2016 04:08AM UTC	97.91	Travis Job 533.3
4	533.4	28 Jan 2016 04:08AM UTC	97.91	Travis Job 533.4

Source Files on build 533

Detailed source file information is not available for this build.

chriso / validator.js / 533
99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 533

chriso / validator.js / 533 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 533

chriso / validator.js / 533
99%

README BADGES
x