expertiza / expertiza / 13370

37%

main: 10%

push

travis-ci-com

Team 1513: Refactor of Late_policies_controller (#2326)

* Simplified 'If' statement on line 58

* Removed Unnecesary Instance Variables in Update

* Instance variable correction

* Simplified elseif conditions in update

* Refactor edit new form (#1)

* Removed somwhat duplicated code from the view, WIP: fixing the controller code to retrieve form data sent by the browser in create action

* consolidated input validation for create and update methods into a single function. Fixed a small syntax error

* fixed common mistakes:
1. changed variable name to conform snake_case from camelCase
2. removed redundant comments

* Fixed a bug: the consolidated input validation code was checking for duplicate name when the name was not changed during edit

* WIP: changed late_policy_controller test to give more specific error message when penalty per unit is less than zero

* Fixed a number of failing tests in late_policies_controller due to mismatch in error message string

* Fixed a typo

Co-authored-by: Shawn Salekin <ssaleki@vclv98-113.hpc.ncsu.edu>

* Refactor edit new form (#2)

* Removed somwhat duplicated code from the view, WIP: fixing the controller code to retrieve form data sent by the browser in create action

* consolidated input validation for create and update methods into a single function. Fixed a small syntax error

* fixed common mistakes:
1. changed variable name to conform snake_case from camelCase
2. removed redundant comments

* Fixed a bug: the consolidated input validation code was checking for duplicate name when the name was not changed during edit

* WIP: changed late_policy_controller test to give more specific error message when penalty per unit is less than zero

* Fixed a number of failing tests in late_policies_controller due to mismatch in error message string

* Fixed a typo

* Fixed failing test

Co-authored-by: Shawn Salekin <ssaleki@vclv98-113.hpc.ncsu.edu>

* Added Method Co... (continued)

42 of 42 new or added lines in 1 file covered. (100.0%)

6749 of 13190 relevant lines covered (51.17%)

13.8 hits per line