Valloric / ycmd / 1197

94%

push

travis-ci

Auto merge of #311 - puremourning:tern-refactor-rename-upstream, r=Valloric

[READY] Support for rename in tern completer

## Tern rename

Tern server supports renames of variables only. It can do this across multiple files, only when it knows about those files. This feature is supported by tern_for_vim, so with the addition of this feature we should have feature-parity on that front.

## Refactoring infrastructure

This re-uses the existing FixIt infrastructure, with no changes to the JSON API. The only change is that this is the first time the command will return changes in multiple files.

The largest change is moving the Cs* classes that are equivalent of the C++ classes representing diagnostics/FixIts to `responses.py`, so they can be shared by other completers.

A Vim client change is required to recognise FixIt responses by the contents of the response, rather than the command name, and to apply the chunks across files.

## FileReadyToParse

Previously, the server would only learn about files if we sent a request (such as a completion request), or by appearing in the loadEagerly list.  Now we pass the file data to the server in the parse request.  This ensures that the server knows about files as soon as possible, so that they are available for completion suggestions and for rename/etc. commands.

## Tests

Simple tests for the single- and multi-file rename cases, both eagerly loaded and picked up from parse request.

## JSON API Changes

None.

## Client changes required

* FixIt commands are now identified by the presence of `'fixit'` entry in the  response
* FixIt commands can now apply across multiple files. The client is responsible for applying the chunks in an appropriate fashion.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/311)
<!-- Reviewable:end -->

46 of 46 new or added lines in 3 files covered. (100.0%)

2597 of 3142 relevant lines covered (82.65%)

0.83 hits per line