sul-dlss / dor-services / 1165

94%

main: 93%

Pull #148

travis-ci

Rename 'groups_which*' to 'roles_which*'

This clarifies the meaning of these methods.  The 'role' is distinguished from a work-'group'.  Argo has a User#roles method that will translate from workgroups to roles, which is the input to the `can*` methods.  This also simplifies all these methods by using constants for admins and viewers.  In case the role definitions need to change, all the `role_which` methods remain as simple method aliases that could be filled in if they require different role array entries.

This is a partial fix for https://github.com/sul-dlss/dor-services/issues/146

58 of 58 new or added lines in 8 files covered. (100.0%)

7300 of 7855 relevant lines covered (92.93%)

97.09 hits per line