expertiza / expertiza / 13146

37%

main: 10%

push

travis-ci-com

E2220: Refactoring reputation_web_service_controller (#2291)

* Deleted commented code

* Split json_generator method, changed param to list

* Fixed tests to use the new methods

* split db_query method, change method names

* Updated the calculate_peer_review_grade method

* Changed method name to pass the test cases

* Updated test case for get_peer_reviews parameters

* Decomposed send_post_request method to abide the SRP principle

* Updated the calculate_peer_review_grade method

* Update reputation_web_service_controller.rb

* Dealt with unnecessary assignments of pass by references

* Updated the instance variables

* Updated and splitted the send_post_request and

* Added comments for the functions

* Removed whitespaces and corrected alignments

* Fixed Rubocop errors

* comment out encryption and decryption resp body

* Fix Post Request failure case

* Fix JSON formation error and HTTP init

* Fix instance variables to flash to show in views

* remove redundant breaks

* Used constants instead of url strings

* fixed failing test cases for client method

* changed loop in calculate peer review to map

* fixed client number not populating after post resp

* change flash messages to different method

* added code comments and split additional info

* formatted code comments and reorganized code

* Formatted code comments

* fixed rubocop errors for trailing whitespaces

* Changed req variable name to post_req

* remove dead code as it will not be used again

* rename response from webservice

* remove decrypt method as its not being used

* changed variable names to meaningful ones

* improve code comments, variable names

* remove aes encryption test

* fix rubocop issues

* Fix typo reqest to request

* fix bug in variable name

* revert changes lost from merge

* fix rubocop

Co-authored-by: Eshwar Chandra Vidhyasagar Thedla <ethedla@vclvm177-155.vcl.ncsu.e... (continued)

115 of 115 new or added lines in 1 file covered. (100.0%)

6784 of 13228 relevant lines covered (51.29%)

14.45 hits per line