suculent / thinx-device-api / #252641489

73%

master: 72%

push

Merge branch 'thinx-class' of github.com:suculent/thinx-device-api into thinx-class

* 'thinx-class' of github.com:suculent/thinx-device-api:
  potential bugfix in purging old users; may cause users to be deleted! needs limits
  typofix in apikeyspec but everything is broken, why?
  MAJOR bugfix in apikey creation, possibly 2 months to 3 weeks old
  non-functional coverage improvements
  from 2 errors, spec and expect fixes
  debugging potential API Key revocation bug by improving expects
  context placement fix
  duplicating some test cases with aim to register new device JRS5 and use its valid udid in test cases over device router
  custom cron job params for test
  adding API key registration and device creation for device operations under test (and dynamic owner, but also dynamic UDID for each test suite)
  improving expects; added type validation in meshes (would be usefuly on every post, but after json-parser middleware)
  make sure git prefetch creates local path as well (responsibility shift-left)
  spec fixes and extending coverage in device/meshes; coverage around 62%
  back to 1 failure; expect fix
  what a mess, will revert or fix AppSessionUserSpec 2 commits back?
  disabling slack in test, improving User spec order to have user available for testing gdpr
  disable sendSlack in test to see if this is the problem

1367 of 3479 branches covered (39.29%)

Branch coverage included in aggregate %.

5637 of 9239 relevant lines covered (61.01%)

5.5 hits per line