expertiza / expertiza / 13112

37%

main: 10%

push

travis-ci-com

E2222. Refactor impersonate_controller.rb (#2347)

* enabled styling in beta branch

* add comments for all the functions in the controller

* modified generate_session function

* modified function names for better readability

* created get_user_name function

* changes for generate_session method

* changes in impersonate method

* Adds test case to check the impersonate action from instructor to superadmin

* Clean Code

* Removed styling from application

* Updated gemgile.lock

* added newline at end in gemfile

* removed newline at end in gemfile

* fixed new line at end of gemfile.lock

* Removed redirect from line 115

* converted if ! to unless

* removed redirect back from line 158

* converted nested if else to if elsif blocks

* Using before_action for checking validity of user name

* Removes display_error_message method

* Adds a error message in impersonation process

* Adds another error check in impersonation process

* remove temp variable from check_if_user_impersonateable

* added error messages at correct locations

* Added various test cases to test who camn impersonate whom

* Added RuboCop Changes

* updated more rubocop errors

* removed dead code andfixed comments

* Adds empty username check and removed main_operation method

* Resolved test failures after rails 5.1 merge

* Resolved test failur for conference controller

* added test case for blank input

* added test case for blank inputs

* fixed running and test cases

* make rails 5 mod

* ruby syntax fix

Co-authored-by: Moksh Rajesh Jain <mrjain@vclv98-229.hpc.ncsu.edu>
Co-authored-by: sskarra <sskarra@ncsu.edu>
Co-authored-by: vijdurk <vijayadurgakona91@gmail.com>
Co-authored-by: Naman Shrimali <namanshrimali@gmail.com>
Co-authored-by: John Bumgardner <john.bumgardner@icloud.com>

35 of 35 new or added lines in 1 file covered. (100.0%)

6778 of 13248 relevant lines covered (51.16%)

14.44 hits per line