• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

optimizely / javascript-sdk / 3126
78%

Build:
DEFAULT BRANCH: master
Ran 30 Mar 2022 10:43PM UTC
Jobs 1
Files 81
Run time 12min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
3126

cron

travis-ci-com

web-flow
chore: Fix package build scripts for git-deps and npm-link symlinks (#746)

## Background
This PR is copied from #481. It was contributed by @jasonkarns a couple of years ago. I just pulled his changes, merged master and resolved conflicts.

## Summary
Main change: `prepublishOnly` is the wrong lifecycle script for building/compiling. prepublishOnly does not run during install for git-deps; nor does it run when a package is being symlinked via npm-link. The correct script is `prepare`.

This PR:
- ensures the build/bundle/compile script is accurately defined as `build` so as to be run properly by the top level `lerna run build` script.
- ensures "clean" is run before building
- ensures `clean` is defined and exposed such that `lerna run clean` works properly
- ensures `build` is invoked during `prepare` lifecycle hook (packing, publishing, git-installing, npm-linking)
- preserves `npm test` being run during `prepublishOnly`
- adds package tarball pattern to gitignore so npm-pack can be run for inspection
- removes unnecessary files from `package.json#files` array (license, changelog, readme, and package.json files are included automatically)
- renames CHANGELOG.MD to be cased properly

## Test plan
No code changes

1100 of 1236 branches covered (89.0%)

Branch coverage included in aggregate %.

9634 of 9809 relevant lines covered (98.22%)

74.56 hits per line

Jobs
ID Job ID Ran Files Coverage
3 3126.3 (SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 30 Mar 2022 10:43PM UTC 0
97.18
Travis Job 3126.3
Source Files on build 3126
  • Tree
  • List 81
  • Changed 0
  • Source Changed 0
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Build #3126
  • 5d526bd7 on github
  • Prev Build on master (#3111)
  • Next Build on master (#3127)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc