39873
39%

Ran 30 Mar 2022 09:56AM UTC

Jobs 3

Files 908

Run time 48min

Badge

Embed ▾

Committed 30 Mar 2022 09:07AM UTC coverage: 35.106% (-0.01%) from 35.118%

Build # 39873

Build Type

push

travis-ci-com

Committed by

borkmann

Commit Message

routing: Consistent conditions for ip rule creation/deletion

In addition to the inconsistency fixed in the previous commit, there is
another we need to fix. On the deletion of ip rules with the form "to
x.x.x.x/x", we check that we are running in ENI mode. We don't perform
the same check on the creation of those rules. Thus, on AKS and
AlibabaCloud, we could theoretically create rules of one form and
attempt to delete the other form.

In practice, this isn't causing a bug because:
- The CIDR used in the "to x.x.x.x/x" form appears to always be
  0.0.0.0/0 and is therefore equivalent to not having a to CIDR
  specified.
- We don't support equivalent flags to --aws-release-excess-ips on AKS
  and AlibabaCloud and, as detailed in the previous commit, that flag is
  necessary to trigger the bug.

Thus, this commit is fixing an inconsistency in the code that doesn't
have any consequence today.

Signed-off-by: Paul Chaignon <paul@cilium.io>

Run Details

45077 of 128403 relevant lines covered (35.11%)

6542.35 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	39873.1	30 Mar 2022 10:02AM UTC	35.1	Travis Job 39873.1
2	39873.2	30 Mar 2022 09:56AM UTC	35.08	Travis Job 39873.2
3	39873.3 (RACE=1 BASE_IMAGE=quay.io/cilium/cilium-runtime:efb92c208c5f1f190243b361cbb43413ca49d534@sha256:8ca66f05327b5affad2bfb09614636f2b0d3fa24a9f40d1b5f86c2ef9ca2e46a LOCKDEBUG=1)	30 Mar 2022 10:41AM UTC	35.14	Travis Job 39873.3

Source Files on build 39873

Detailed source file information is not available for this build.

cilium / cilium / 39873
39%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 39873

cilium / cilium / 39873 39%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 39873

cilium / cilium / 39873
39%

README BADGES
x