uber / NullAway / #810
93%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 73
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
#810

push

github-actions

web-flow 
Get NullAway building with NullAway (#560)

With this change, running `./gradlew build` on JDK 11 will also run the task `:nullaway:buildWithNullAway` to ensure that NullAway (i.e., the current version of NullAway being built) reports no errors on NullAway itself.  Some notes on the changes:
* We build with the `CheckOptionalEmptiness`, `AcknowledgeRestrictiveAnnotations`, and `CastToNonNullMethod` options provided, to maximize error discovery.
* Since we use `AcknowledgeRestrictiveAnnotations`, changing annotations in different versions of Error Prone can impact what warnings NullAway reports on itself.  Hence, we only run the `buildWithNullAway` task if we are building against the latest version of Error Prone we have tested with (currently 2.11.0).  Further, building with this latest Error Prone version is now the default, to catch NullAway-on-NullAway issues more easily on local builds.  All CI build configs (including testing with older EP versions) remain the same.

* I don't think the code changes fix any serious bugs, but they do clarify the design in places (e.g. properly marking fields / returns as `@Nullable`).  I had to add several `castToNonNull` calls.  Most were for either (1) reading out of a map where we know the key is present somehow or (2) getting the enclosing class symbol for some `Tree`, in various places where we know it will not return `null`.

4784 of 5188 relevant lines covered (92.21%)

0.92 hits per line

Jobs
ID Job ID Ran Files Coverage
1 #810.1 0
92.21
Source Files on build #810
Detailed source file information is not available for this build.