npm / cli / #3928

97%

push

fix(unpublish): properly apply publishConfig (#4601)

The tests for unpublish were mocked so heavily they weren't actually
asserting anything.  In rewriting them several bugs were found.

 - `write=true` was not being consistenly used when fetching packument
   data, it is now.
 - The decision on when to load the local package.json file was not
   working at all, that has been fixed.  If the cwd contains a
   package.json whose name matches the package you are uninstalling, the
   local package.json will be read and its publishConfig applied to your
   request.
 - dead code inside the `npm unpublish` path was removed.  There is no
   need to check if you are unpublishing the last version here, you're
   already unpublishing the entire project.
 - publishConfig is now being applied through the config flatten method,
   not a raw object assignment.

3279 of 3382 branches covered (96.95%)

Branch coverage included in aggregate %.

30 of 30 new or added lines in 1 file covered. (100.0%)

5857 of 6013 relevant lines covered (97.41%)

28.96 hits per line