aldryn / aldryn-newsblog / 1189
91%

DEFAULT BRANCH: master
Ran
Jobs 11
Files 36
Run time 26min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1189

Pull #348

travis-ci

trawick 
Return empty menu if NewsBlog not enabled as an application

A customer accidentally enabled Aldryn NewsBlog as an attached menu
but not as an application.  Page loads tried to generate navigation, which
blew up generating the menu (below).  I edited the template on production
to disable navigation in order to find and fix the misconfiguration.

File "/var/www/FOO/env/lib/python3.4/site-packages/classytags/core.py", line 106, in render
    return self.render_tag(context, **kwargs)
  File "/var/www/FOO/env/lib/python3.4/site-packages/classytags/helpers.py", line 86, in render_tag
    data = context.new(self.get_context(context, **kwargs))
  File "/var/www/FOO/env/lib/python3.4/site-packages/menus/templatetags/menu_tags.py", line 133, in get_context
    nodes = menu_pool.get_nodes(request, namespace, root_id)
  File "/var/www/FOO/env/lib/python3.4/site-packages/menus/menu_pool.py", line 256, in get_nodes
    nodes = self._build_nodes(request, site_id)
  File "/var/www/FOO/env/lib/python3.4/site-packages/menus/menu_pool.py", line 215, in _build_nodes
    nodes = menu.get_nodes(request)
  File "/var/www/FOO/env/lib/python3.4/site-packages/aldryn_newsblog/menu.py", line 35, in get_nodes
    app = apphook_pool.get_apphook(self.instance.application_urls)
  File "/var/www/FOO/env/lib/python3.4/site-packages/cms/apphook_pool.py", line 97, in get_apphook
    raise ImproperlyConfigured('No registered apphook %r found' % app_name)
django.core.exceptions.ImproperlyConfigured: No registered apphook '' found
Pull Request #348: Return empty menu if NewsBlog not enabled as an application

2132 of 2369 relevant lines covered (90.0%)

8.94 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
4
81.58
 -6.66% aldryn_newsblog/menu.py
Jobs
ID Job ID Ran Files Coverage
1 1189.1 (TOXENV=flake8) 0
Travis Job 1189.1
6 1189.6 (TOXENV=py34-dj17-sqlite-cms32) 36
89.15
 Travis Job 1189.6
7 1189.7 (TOXENV=py34-dj17-sqlite-cms31) 36
89.15
 Travis Job 1189.7
8 1189.8 (TOXENV=py34-dj17-sqlite-cms30) 36
89.11
 Travis Job 1189.8
10 1189.10 (TOXENV=py27-dj17-sqlite-cms31) 36
88.98
 Travis Job 1189.10
11 1189.11 (TOXENV=py27-dj17-sqlite-cms30) 36
88.94
 Travis Job 1189.11
12 1189.12 (TOXENV=py27-dj16-sqlite-cms32) 36
89.74
 Travis Job 1189.12
13 1189.13 (TOXENV=py27-dj16-sqlite-cms31) 36
89.74
 Travis Job 1189.13
14 1189.14 (TOXENV=py27-dj16-sqlite-cms30) 36
89.7
 Travis Job 1189.14
16 1189.16 (TOXENV=py26-dj16-sqlite-cms31) 36
89.83
 Travis Job 1189.16
17 1189.17 (TOXENV=py26-dj16-sqlite-cms30) 36
89.78
 Travis Job 1189.17
Source Files on build 1189
Coverage ∆ File Lines Relevant Covered Missed Hits/Line