expertiza / expertiza / 12505

37%

main: 10%

push

travis-ci-com

<a href="https://github.com/expertiza/expertiza/commit/<a class=hub.com/expertiza/expertiza/commit/<a class="double-link" href="https://git"><a class=hub.com/expertiza/expertiza/commit/70d66a209b47ffae60644506eba3fa2c132c1cc7">70d66a209<a href="https://github.com/expertiza/expertiza/commit/70d66a209b47ffae60644506eba3fa2c132c1cc7">&quot;&gt;E2126. Refactor account_request_controller.rb  (#2117)

* Run migrate

* Refactored account_request_controller

* Fixed refactoring of create_approved_user method

* Separated notifying of super users about new account request from creation of record

* Renamed user_existed to user_exists. Moved requested_user validation and saving to own method

* Made error message more readable. Changed how paramsare being passed to save_reqeuested_user

* Updated error message on line 26

* Revert &amp;quot;Updated error message on line 26&amp;quot;

This reverts commit &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/expertiza/expertiza/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/expertiza/expertiza/commit/<a class="double-link" href="https://github.com/expertiza/expertiza/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/expertiza/expertiza/commit/71e62c9f2381d26512b38107de09a77d52b863b0">71e62c9f2</a><a href="https://github.com/expertiza/expertiza/commit/70d66a209b47ffae60644506eba3fa2c132c1cc7">&quot;&gt;71e62c9f2&lt;/a&gt;&lt;a href=&quot;https://github.com/expertiza/expertiza/commit/70d66a209b47ffae60644506eba3fa2c132c1cc7&quot;&gt;&amp;lt;a href=&quot;https://github.com/expertiza/expertiza/commit/70d66a209b47ffae60644506eba3fa2c132c1cc7&quot;&gt;.

* Revert</a> &quot;Merge branch &#39;beta&#39; of https://github.com/majuabir/expertiza into beta&quot;

This reverts commit &lt;a class=&quot;double-link&quot; href=&quot;https://github.com/expertiza/expertiza/commit/<a class="double-link" href="https://github.com/expertiza/expertiza/commit/57a7f484239c306e963ec93d5ef8b7ff4e194210">57a7f4842</a>&quot;&gt;57a7f4842&lt;/a&gt;, reversing
changes made to 71e62c9f2381d26512b38107de09a77d52b863b0.

* Reverted to working code

* Updated tests to include new error message

* Refactored create_requested_user_record into 3 methods and made variables/errormessages more readable

* buggy captcha implementation; testing if works on server

* Updated error message on line 34

* pushed captcha

* Fixed recaptcha verification bug; Reverted conference controller to original state

* Added method comments

* Added method comments to refactored and new methods

* extra space ch... (continued)

6395 of 14127 relevant lines covered (45.27%)

17.45 hits per line