npm / cli / #3649

97%

latest: 97%

push

fix(log): pass in logger to external modules

Most of these module use npm-registry-fetch under the hood, which will
log things like the `npm-notice` header if seen.  Currently we aren't
passing in a logger to them, which means that log message is never seen,
among any other logged messages those modules may need to make.

I added tests where I could. Some tests were in a state where the entire
libnpm* module was an empty mocked function, so asserting that it got
passed a `log` attribute was onerous.

3301 of 3404 branches covered (96.97%)

Branch coverage included in aggregate %.

5827 of 5982 relevant lines covered (97.41%)

29.51 hits per line