npm / cli / #3619

97%

latest: 97%

push

fix(arborist): load actual tree on named updates

Arborist was not loading the actual tree when using named updates for
global updates, that would result in removing all previously installed
deps from a global install anytime the user would try to run
`npm update <pkgname>`.

This changeset fixes the problem by allowing the load of the actual tree
if the `global` and `update.names` options are defined.

Added a few more tests to illustrate but some of the snapshots already
included were actually demonstrating the problem by having empty trees
as result, these are now also updated with the expected tree result.

Fixes: https://github.com/npm/cli/issues/3175

3301 of 3404 branches covered (96.97%)

Branch coverage included in aggregate %.

5822 of 5977 relevant lines covered (97.41%)

29.53 hits per line