ivmai / bdwgc / 1205

77%

push

travis-ci-com

Workaround crash in FreeBSD rand() by avoiding its concurrent usage

Issue #414 (bdwgc).

The standard specifies rand() as not a thread-safe API function.  Thus,
the concurrent usage of libc rand() should be avoided.

Redefine the standard rand() in disclaim_[weakmap_]test with a trivial
(yet sufficient for the test purpose) implementation to avoid crashes
inside rand() on some targets (e.g. FreeBSD 13.0).

* tests/disclaim_test.c [LINT2] (GC_API_PRIV): Do not define.
* tests/disclaim_weakmap_test.c [LINT2] (GC_API_PRIV): Likewise.
* tests/disclaim_test.c [LINT2] (GC_random): Do not declare.
* tests/disclaim_weakmap_test.c [LINT2] (GC_random): Likewise.
* tests/disclaim_test.c [GC_PTHREADS || LINT2] (NOT_GCBUILD): Define.
* tests/disclaim_weakmap_test.c [GC_PTHREADS || LINT2] (NOT_GCBUILD):
Likewise.
* tests/disclaim_test.c [GC_PTHREADS || LINT2]: Include gc_priv.h.
* tests/disclaim_test.c [GC_PTHREADS || LINT2] (GC_rand): New static
function.
* tests/disclaim_weakmap_test.c [GC_PTHREADS || LINT2] (GC_rand):
Likewise.
* tests/disclaim_test.c [GC_PTHREADS || LINT2] (rand): Define to
GC_rand() (instead of (int)GC_random()); add comment.
* tests/disclaim_weakmap_test.c [GC_PTHREADS || LINT2] (rand):
Likewise.
* tests/disclaim_weakmap_test.c [GC_PTHREADS || LINT2]: Include
gc_priv.h before gc/gc_mark.h; add comment.

6 of 6 new or added lines in 2 files covered. (100.0%)

7207 of 9817 relevant lines covered (73.41%)

10427036.94 hits per line