158
63%

Ran 21 Dec 2015 05:34PM UTC

Jobs 4

Files 2

Run time 40s

Badge

Embed ▾

pending completion

Build # 158

Build Type

push

travis-ci

Committed by

Ichimonji10

Commit Message

Use urljoin in `pulp_smash.utils`

Fix #58:

> Many places in the tests combine URLs and paths with simple string addition.
> This has the potential to produce incorrect results. […] Pulp should produce
> paths that behave correctly with urljoin, and we've had problems in the past
> with developers making "relative paths" that have a leading slash.

Using urljoin instead of plain string concatenation lets Pulp Smash test the
paths returned by Pulp. If Pulp returns a relative path with a leading slash,
plain string concatenation will produce a path containing a (typically harmless
but incorrect) `//`, but urljoin will produce a just-plain-wrong URL.

Test results both before and after change:

    ============  =============================
    Pulp Version  Test Suite Results
    ============  =============================
    2.7           OK (skipped=13)
    dev (2.8)     FAILED (errors=2, skipped=13)
    ============  =============================

Command used:

    PULP_SMASH_CONFIG_FILE=$PS_CONFIG \
    python -m unittest2 discover pulp_smash.tests

Run Details

145 of 198 relevant lines covered (73.23%)

2.9 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	158.1	21 Dec 2015 05:34PM UTC	73.23	Travis Job 158.1
2	158.2	21 Dec 2015 05:34PM UTC	72.22	Travis Job 158.2
3	158.3	21 Dec 2015 05:34PM UTC	72.22	Travis Job 158.3
4	158.4	21 Dec 2015 05:34PM UTC	72.22	Travis Job 158.4

Source Files on build 158

Detailed source file information is not available for this build.

PulpQE / pulp-smash / 158
63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 158

PulpQE / pulp-smash / 158 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 158

PulpQE / pulp-smash / 158
63%

README BADGES
x