STEllAR-GROUP / hpx / #630

83%

push

Merge #5703

5703: Fix `counting_iterator` container tests r=msimberg a=msimberg

The random_access_iterator test requires at least two elements in the container. I've added an assertion to the test to make the precondition slightly more obvious. Fixes these types of failures: https://cdash.cscs.ch/testDetails.php?test=60179258&build=205784, i.e.
```
using seed: 1639331791
/dev/shm/hpx/src/libs/core/iterator_support/tests/unit/iterator_tests.hpp(106): test '*i1 == v2' failed in function 'void tests::input_iterator_test(Iterator, T, T) [Iterator = hpx::util::counting_iterator<std::__wrap_iter<int *>>, T = std::__wrap_iter<int *>]'
/dev/shm/hpx/src/libs/core/iterator_support/tests/unit/iterator_tests.hpp(107): test '*i == v2' failed in function 'void tests::input_iterator_test(Iterator, T, T) [Iterator = hpx::util::counting_iterator<std::__wrap_iter<int *>>, T = std::__wrap_iter<int *>]'
/dev/shm/hpx/src/libs/core/iterator_support/tests/unit/iterator_tests.hpp(66): test 'v == val' failed in function 'void tests::trivial_iterator_test(const Iterator, const Iterator, T) [Iterator = hpx::util::counting_iterator<std::__wrap_iter<int *>>, T = std::__wrap_iter<int *>]'
/dev/shm/hpx/src/libs/core/iterator_support/tests/unit/iterator_tests.hpp(72): test '*k == val' failed in function 'void tests::trivial_iterator_test(const Iterator, const Iterator, T) [Iterator = hpx::util::counting_iterator<std::__wrap_iter<int *>>, T = std::__wrap_iter<int *>]'
/dev/shm/hpx/src/libs/core/iterator_support/tests/unit/iterator_tests.hpp(66): test 'v == val' failed in function 'void tests::trivial_iterator_test(const Iterator, const Iterator, T) [Iterator = hpx::util::counting_iterator<std::__wrap_iter<int *>>, T = std::__wrap_iter<int *>]'
/dev/shm/hpx/src/libs/core/iterator_support/tests/unit/iterator_tests.hpp(72): test '*k == val' failed in function 'void tests::trivial_iterator_test(const Iterator, const Iterator, T) [Iterator = hpx::util::counting_iterator<std::__w... (continued)

9 of 9 new or added lines in 2 files covered. (100.0%)

164196 of 191107 relevant lines covered (85.92%)

2121607.24 hits per line