CyclopsMC / IntegratedDynamics / #478772506

16%

master-1.21-lts: 45%

push

github-actions

<a href="https://github.com/CyclopsMC/IntegratedDynamics/commit/<a class=hub.com/CyclopsMC/IntegratedDynamics/commit/aa4416185121b08339c466ef17c59e8057e24771">aa4416185<a href="https://github.com/CyclopsMC/IntegratedDynamics/commit/aa4416185121b08339c466ef17c59e8057e24771">&quot;&gt;Fix BlockCable$BlockColor#getColor not checking null args

In `IBlockColor#getColor(BlockState, IBlockDisplayReader, BlockPos, int)` the second and third argument, the world and block pos, are annotated with `Nullable`. These arguments can be supplied with a null value when calling for example `BlockRendererDispatcher#renderBlock`.

The implementation of `IBlockColor#getColor` in `BlockCable$BlockColor` passes the world and block pos arguments to `CableHelpers#getFacade`. `CableHelpers#getFacade` will throw a null pointer exception for a null world argument due to the first line in `TileHelpers#getSafeTile` (https://github.com/CyclopsMC/CyclopsCore/blob/</a><a class="double-link" href="https://github.com/CyclopsMC/IntegratedDynamics/commit/<a class="double-link" href="https://github.com/CyclopsMC/IntegratedDynamics/commit/41b14dfab4ede75972316d6393fbb3dc86aefaa8">41b14dfab</a>">41b14dfab</a><a href="https://github.com/CyclopsMC/IntegratedDynamics/commit/aa4416185121b08339c466ef17c59e8057e24771">/src/main/java/org/cyclops/cyclopscore/helper/TileHelpers.java#L63).

This pull request prevents the null pointer exception by checking whether the world or block pos arguments are null in `BlockCable$BlockColor#getColor` before they are passed to `CableHelpers#getFacade`.

3374 of 21027 relevant lines covered (16.05%)

0.16 hits per line