twitter / CocoaSPDY / 349

80%

master: %

push

travis-ci

Workaround for caching with iOS 8 and NSURLSession.

Observationally, we've seen the NSURL loading system fail to insert
items into the NSURLCache when using NSURLSession and iOS 7/8.
NSURLConnection works fine on all these, and NSURLSession works fine on
iOS 9. Best guess is there's a bug in the NSURLProtocol implementation
that fails to insert into the cache.

So, here we are creating a workaround for that specific case. CocoaSPDY
will buffer the data internally, up to a certain size limit based on the
cache size, and will manually insert into the cache when the response is
done. This could potentially be expanded in the future for unclaimed,
finished push responses, but for now those are excluded.

This change also adds a few additional caching-related unit tests.

64 of 64 new or added lines in 2 files covered. (100.0%)

3651 of 4594 relevant lines covered (79.47%)

86.83 hits per line