• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

hypothesis / h / 9314
70%
master: 97%

Build:
Build:
LAST BUILD BRANCH: realtime-update-v1-h-only-1
DEFAULT BRANCH: master
Ran 10 Dec 2015 01:08PM UTC
Jobs 1
Files 92
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
9314

push

travis-ci

nickstenning
Fix standalone annotation page realtime updates for replies to replies

This commit fixes a bug where a standalone annotation page only receives
realtime updates for replies on that page if the top-level annotation on
the page is also the root of its message thread.

The annotation `references` field contains the ids of all ancestors in
the message thread, from oldest to newest -- that is, the earlier in the
references field an id appears, the higher it is in the message tree.

In order to receive realtime updates for all messages in the part of the
thread displayed on a standalone annotation page, we need to ask for:

- all updates in which the id in the URL matches the id in the
  annotation (i.e. updates to the top-most displayed annotation, which
  may itself be a reply).

- all updates in which the id in the URL *is contained in* the
  `references` field of an annotation (i.e. updates for any annotation
  lower in the message thread)

Previously, this code requested all updates in which the id *was the
first entry* in the references field, which is only ever true for the
root of a message thread, meaning that it only ever worked on standalone
annotation pages for top-level annotations, and not on pages for
replies.

2602 of 3715 relevant lines covered (70.04%)

0.7 hits per line

Jobs
ID Job ID Ran Files Coverage
1 9314.1 10 Dec 2015 01:08PM UTC 0
70.04
Travis Job 9314.1
Source Files on build 9314
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #9314
  • 4c4bbd1f on github
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc