npm / cli / #3257

97%

latest: 97%

push

fix: shrinkwrap setting incorrect lockfileVersion

Fix: #3962

When created from a hidden lockfile, shrinkwrap was always setting the
lockfileVersion to 3. The shrinkwrap command also needed to be updated
to log the correct message based on the lockfileVersion config instead
of the static lockfileVersion.

With these fixes, it was possible to log a better message whenever we
are changing the lockfileVersion, either from a config or any existing
lockfile.

Lastly, the tests for shrinkwrap were completely refactored to use the
real npm and test all conceivable scenarios, as well as removing usage
of `util.promisify` in favor of `fs.promises` now that we've dropped
support for Node 10.

3262 of 3362 branches covered (97.03%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 1 file covered. (100.0%)

5541 of 5694 relevant lines covered (97.31%)

28.38 hits per line