api-platform / core / #27990

29%

master: 37%

push

github

<a href="https://github.com/api-platform/core/commit/<a class=hub.com/api-platform/core/commit/<a class="double-link" href="https://git"><a class=hub.com/api-platform/core/commit/2625c8159c5eac1a2721299e106a1e354aadd862">2625c8159<a href="https://github.com/api-platform/core/commit/2625c8159c5eac1a2721299e106a1e354aadd862">&lt;a href=&quot;https://github.com/api-platform/core/commit/2625c8159c5eac1a2721299e106a1e354aadd862&quot;&gt;&amp;quot;&amp;gt;Improved recursion handling in EagerLoadingExtension (#4377)

* feat: Avoid eager joining back to the just visited parent

* fix: Remove unnecessary duplicate select statement

This exact select statement is already added a few lines above. The only
exception is when fetchPartial is active, and in that case the current
implementation is wrong anyways, because it always adds the full select.

When this &amp;amp;quot;temporary&amp;quot; solution for avoiding recursion was implemented,
the duplicated line above was not yet there:
https://github.com/api-platform/core/blob/&lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/api-platform/core/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/api-platform/core/commit/5ba518014e2770e1ad5686b0124b2db45245fee5&quot;&gt;5ba518014&lt;/a&gt;&quot;&gt;5ba518014&lt;/a&gt;&lt;a href=&quot;https://github.com/api-platform/core/commit/2625c8159c5eac1a2721299e106a1e354aadd862&quot;&gt;/src/Bridge/Doctrine/Orm/Extension/EagerLoadingExtension.php#L148

But later, the duplicated statement was added, and the select statement
inside the &quot;Avoid recursion&quot; case was made obsolete:
https://github.com/api-platform/core/commit/</a><a class="double-link" href="https://github.com/api-platform/core/commit/<a class="double-link" href="https://github.com/api-platform/core/commit/e34427a9f3e356a2d74350a035421dff6e499634">e34427a9f</a>">e34427a9f</a><a href="https://github.com/api-platform/core/commit/2625c8159c5eac1a2721299e106a1e354aadd862">

* refactor(eager loading): Avoid joining unnecessary recursive relations

* fix: prevent adding same alias twice; doctrine does not like it

Co-authored-by: Pirmin Mattmann <pimattmann@gmail.com>

13559 of 17006 relevant lines covered (79.73%)

14.87 hits per line