npm / cli / #3225

97%

latest: 97%

push

fix: allow `--lockfile-version` config to be string and coerce to number

As all CLI input is considered to be string, eg. a
"npm install --lockfile-version 3" would fail with the error messages:

```
npm WARN invalid config lockfile-version="3" set in command line options
npm WARN invalid config Must be one of: null, 1, 2, 3
```

Until we have a config system that supports setting type and possible values
of configs, we have to specify all string and number values for the
`lockfile-version`, but we coerce all values to numbers in the flattener.

Co-authored-by: @voxpelli
Co-authored-by: @isaacs

PR-URL: https://github.com/npm/cli/pull/3949
Credit: @lukekarrys
Close: #3949
Reviewed-by: @isaacs

3254 of 3354 branches covered (97.02%)

Branch coverage included in aggregate %.

5533 of 5686 relevant lines covered (97.31%)

28.36 hits per line