4670
90%
master: 93%

Ran 06 Dec 2015 10:55PM UTC

Jobs 6

Files 141

Run time 2min

Badge

Embed ▾

pending completion

Build # 4670

Build Type

push

travis-ci

Committed by

keradus

Commit Message

feature #1493 Added MethodArgumentDefaultValueFixer (lmanzke)

This PR was submitted for the 1.11 branch but it was merged into the 1.12 branch instead (closes #1493).

Discussion
----------

Added MethodArgumentDefaultValueFixer

Hey guys, glad to be doing my first PR for you :).

My colleague @dereuromark opened an issue for a new fixer suggestion a while ago.
https://github.com/FriendsOfPHP/PHP-CS-Fixer/issues/1462

Here is the PR implementing it. I took his solution and refactored it, please feel free to have a look.

I tried to make it as readable as possible.

Maybe you have some suggestion on how finding the next occurrence of a Variable OR certain token might be done more conveniently. I thought I could use

```
$tokens->getNextTokenOfKind(T_VARIABLE)
```

here, but it does not work that way ;).

Looking forward to your feedback!

Best regards,

Lucas

Commits
-------

a048e25 Added MethodArgumentDefaultValueFixer

Coverage Stats

4604 of 5243 relevant lines covered (87.81%)

357.68 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	4670.2	06 Dec 2015 10:52PM UTC	86.43	Travis Job 4670.2
3	4670.3	06 Dec 2015 10:52PM UTC	86.59	Travis Job 4670.3
4	4670.4 (SYMFONY_VERSION="~2.7")	06 Dec 2015 10:53PM UTC	86.8	Travis Job 4670.4
5	4670.5 (SYMFONY_VERSION="~3.0@dev" COMPOSER_FLAGS="--prefer-stable")	06 Dec 2015 10:53PM UTC	86.8	Travis Job 4670.5
6	4670.6	06 Dec 2015 10:56PM UTC	90.41	Travis Job 4670.6
7	4670.7	06 Dec 2015 10:56PM UTC	79.26	Travis Job 4670.7

Source Files on build 4670

Detailed source file information is not available for this build.

FriendsOfPHP / PHP-CS-Fixer / 4670
90%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4670

FriendsOfPHP / PHP-CS-Fixer / 4670 90% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4670

FriendsOfPHP / PHP-CS-Fixer / 4670
90%
master: 93%

README BADGES
x