jshint / jshint / 2349
100%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 13
Run time 10s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
2349

Pull #2795

travis-ci

jugglinmike 
[[Fix]] Correct `unused` for function-scoped vars

In the absence of the `funcscope` option, JSHint validates
function-scoped variable references as though they were block scoped.
JSHint does not apply block-scoping semantics to reference counting,
however: re-declarations within nested blocks are *not* considered
distinct when determining whether a given binding is used.

Ensure that when a variable is re-declared within the same function
scope, usage tracking is "shared" across all identifiers.

This change required correcting two existing tests. Both alterations
removed warnings, meaning they do not reflect a backwards-incompatible
change in behavior.

1. In the following source code, the variable `ok` is used, so JSHint
   should not report otherwise:

        function(match) {
          var ch = this.string.charAt(this.pos);
          if (typeof match == "string") var ok = ch == match;
          else var ok = ch && (match.test ? match.test(ch) :
          if (ok) {++this.pos; return ch;}
        }

2. In the following source code, the `var` declaration for `d` is not
   technically used, but it is also invalid due to ES2015 block scoping
   semantics. Because JSHint continues to correctly emit an error for
   this code, the removal of the "unused" warning has little practical
   effect.

        function sup(a) {
          var b = 4;
          let c = 5;
          let d = 6;
          if (false) {
            var d = 7;
          }
          return b + c + a + d;
        }
Pull Request #2795: [[Fix]] Correct `unused` for function-scoped vars

3943 of 4042 relevant lines covered (97.55%)

6274.41 hits per line

Jobs
ID Job ID Ran Files Coverage
1 2349.1 13
97.53
 Travis Job 2349.1
2 2349.2 13
97.48
 Travis Job 2349.2
Source Files on build 2349
Coverage ∆ File Lines Relevant Covered Missed Hits/Line