farhadi / node-smpp / 157

80%

push

travis-ci-com

New SMPP Proxy-protocol support implementation. Fixes #190 (#191)

* New SMPP Proxy-protocol support implementation. Fixes #190

Since it worked on already established sockets, only was decoding proxy-protocol headers on non-tls connections. Trying to use it on tls connections didn't work (check referenced issue)

[Proxywrap](https://www.npmjs.com/package/findhit-proxywrap) is a tls/net server interface wrapper which strips the proxy protocol header and stores the relevant information into the socket. After that, it automatically disengages and sends the control to the real tls/net server.
[No known vulnerabilities within the 5 past years](https://snyk.io/vuln/npm:findhit-proxywrap)

Since this is an experimental feature, if no `enable_proxy_protocol_detection: true` option is provided, standard servers are used and the implementation is completely ignored.

- Decode IPv4 proxy protocol header (Non-tls & tls)
- Decode IPv6 proxy protocol header (Non-tls & tls)
- Bypass proxy protocol header detection if no proxy-protocol header is provided (Non-tls & tls)
- Fail with a too long proxy header (Non-tls & tls)

- Support for Nodejs < v4 (2015) has been dropped: Changes to supported Nodejs versions due compatibility issues of findhit-proxywrap.
- On proxied, non-tls connections (with Nodejs < v8): Proxywrap shows some misbehaviour with the way this library inherits from the net server, the socket looses the ability to emit events. As a minor-fix, the socket.emit method is backed up and restored after the proxying to the net server, making everything work as expected.

* Fix merge bug

292 of 421 branches covered (69.36%)

55 of 55 new or added lines in 1 file covered. (100.0%)

618 of 773 relevant lines covered (79.95%)

860.93 hits per line