• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

optimizely / javascript-sdk / 2932
78%

Build:
DEFAULT BRANCH: master
Ran 05 Oct 2021 05:32PM UTC
Jobs 7
Files 72
Run time 12min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
2932

push

travis-ci-com

web-flow
feat: Added optional args to `logger.log` to format string only when log level applies (#706)

## Summary
Message formatting is performance heavy. The logger takes formatted message as a parameter, which means message formatting is being done for all types of logs even in cases when the log level does not apply. This PR adds arguments array to the `log` function to carry token values. Logger already has the functionality to `sprintf` based on extra args if the log level applies. This will increase performance in cases where log level is restricted to more conservative ones such as `ERROR`.

## Test plan
- All Unit tests pass
- Manually tested thoroughly with optimizely-sdk package. A follow up PR for the main package will be created after this is merged and released.

976 of 1099 branches covered (88.81%)

Branch coverage included in aggregate %.

8894 of 9077 relevant lines covered (97.98%)

487.49 hits per line

Jobs
ID Job ID Ran Files Coverage
2 2932.2 (SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 05 Oct 2021 05:32PM UTC 0
96.99
Travis Job 2932.2
5 2932.5 (SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 05 Oct 2021 05:38PM UTC 0
96.99
Travis Job 2932.5
6 2932.6 (SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 05 Oct 2021 05:40PM UTC 0
96.99
Travis Job 2932.6
7 2932.7 (SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 05 Oct 2021 05:40PM UTC 0
96.99
Travis Job 2932.7
8 2932.8 (SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 05 Oct 2021 05:40PM UTC 0
96.99
Travis Job 2932.8
9 2932.9 (SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 05 Oct 2021 05:40PM UTC 0
96.99
Travis Job 2932.9
10 2932.10 (SDK=javascript SDK_BRANCH=$TRAVIS_PULL_REQUEST_BRANCH) 05 Oct 2021 05:40PM UTC 0
96.99
Travis Job 2932.10
Source Files on build 2932
Detailed source file information is not available for this build.
  • Back to Repo
  • Build #2932
  • 4f373971 on github
  • Prev Build on master (#2920)
  • Next Build on master (#2940)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc