276
100%
stable: 100%

Ran 29 Nov 2015 11:32PM UTC

Jobs 6

Files 74

Run time 42s

Badge

Embed ▾

pending completion

Build # 276

Build Type

push

travis-ci

Committed by

sirosen

Commit Message

Refactored action verification to be multi-phase

The structure of "verify_can_exec" being invoked as part of execute() was a
little funky, and it required that each action type do the same dance at the
beginning of execution. True, this is slated for removal, but that is a long
term goal, and in the meantime this has grown into a bit of a mess. Instead,
differentiates __call__() from execute() on actions by having __call__() do
verification before execution. Additionally, breaks down verification into two
steps: get a code (which tells us not only if we can proceed, but why or why
not), and then translate that code to a True/False value to tell us whether or
not to proceed. Without this breakdown, the 'OK' code has to act somewhat
truthy, which is not necessarily correct if we want other codes to allow
execution. For example, a "target exists" code could be fine for copy actions,
but still allows for more informative messaging than a raw "OK".

Run Details

1305 of 1308 relevant lines covered (99.77%)

5.97 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	96.0	-4.0%	salve/action/base.py

Jobs

ID	Job ID	Ran	Files	Coverage
2	276.2	29 Nov 2015 11:32PM UTC	74	99.77	Travis Job 276.2
3	276.3	29 Nov 2015 11:32PM UTC	74	99.46	Travis Job 276.3
4	276.4	29 Nov 2015 11:32PM UTC	74	99.46	Travis Job 276.4
5	276.5	29 Nov 2015 11:32PM UTC	74	99.46	Travis Job 276.5
6	276.6	29 Nov 2015 11:32PM UTC	74	99.46	Travis Job 276.6
7	276.7	29 Nov 2015 11:32PM UTC	74	99.77	Travis Job 276.7

Source Files on build 276

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

sirosen / SALVE / 276
100%
stable: 100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 276

sirosen / SALVE / 276 100% stable: 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 276

sirosen / SALVE / 276
100%
stable: 100%

README BADGES
x