6145
75%

Ran 26 Aug 2021 05:40PM UTC

Jobs 1

Files 274

Run time 80min

Badge

Embed ▾

pending completion

Build # 6145

Build Type

cron

travis-ci-com

Committed by

web-flow

Commit Message

Problem: calling randombytes_close with libsodium can crash Contexts in other threads (#4242)

* add opt-out for randombytes_close

Problem: randombytes_close is either a no-op or unsafe when a Context is running.

Unfortunately, there does not appear to be a single always correct choice,
so let builders pick between two not-great options.

Opting out can leak an FD on /dev/urandom which may need to be closed explicitly.
However, with the default behavior,
using multiple contexts with CURVE can crash with no application-level workaround available.

randombytes_close is not threadsafe and calling it while still in use by a Context can cause a crash.

For implementations using /dev/[u]random, this can leave up to one leftover FD per process.

The libsodium docs suggest that this function rarely needs to be called explicitly.

Run Details

11924 of 15899 relevant lines covered (75.0%)

32880.13 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	87.5	-0.69%	src/tcp_address.cpp
2	82.61	-8.7%	src/clock.cpp
3	83.49	-0.69%	src/ctx.cpp
5	87.0	-0.48%	src/socket_base.cpp

Jobs

ID	Job ID	Ran	Files	Coverage
9	6145.9 (GH_TOKEN=[secure] OBS_STABLE_TOKEN=[secure] OBS_DRAFT_TOKEN=[secure] SONARQUBE_TOKEN=[secure] BUILD_TYPE=coverage CURVE=tweetnacl GSSAPI=enabled PGM=enabled NORM=enabled TIPC=enabled IPv6=ON TLS=enabled DRAFT=enabled)	26 Aug 2021 05:40PM UTC	274	75.0	Travis Job 6145.9

zeromq / libzmq / 6145
75%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 6145

zeromq / libzmq / 6145 75%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 6145

zeromq / libzmq / 6145
75%

README BADGES
x