2529
100%

Ran 18 Nov 2015 11:54PM CUT

Jobs 6

Files 43

Run time 1min

Badge

Embed ▾

pending completion

Build # 2529

Build Type

Pull #2809

travis-ci

Committed by

defunctzombie

Commit Message

router: add async route handler support

While the async/await feature is still highly experimental and not
official, it does have preliminary support in tools like babel. There
are even blog posts [1] about how to use the async/await feature with
express routes.

However, these posts along with issue #2789 and #2788 show that using
async/await is still a bit of a manual process and not clear. This
change inspects the return value of a route handler to see if it is
potentially a pomise. If the return value appears to be a promise then
we attach to the error handler of the promise via .catch()

Now a user who is using babel can write the following without needing
any wrap functions as most examples to date require.

```js
app.get('/', async (req, res, next) => {
    let user = await User.findById(); // assuming .findById() returns a primise
    let org = await Org.findById();
    res.json({
        user: user,
        org: org,
    });
});
```

[1] https://strongloop.com/strongblog/async-error-handling-expressjs-es7-promises-generators/

Pull Request Pull Request #2809: router: add async route handler support

Run Details

1814 of 1824 relevant lines covered (99.45%)

2385.49 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
5	92.65	-2.67%	lib/router/layer.js

Jobs

ID	Job ID	Ran	Files	Coverage
1	2529.1	18 Nov 2015 11:54PM CUT	43	99.45	Travis Job 2529.1
2	2529.2	18 Nov 2015 11:54PM CUT	43	99.45	Travis Job 2529.2
3	2529.3	18 Nov 2015 11:54PM CUT	43	99.45	Travis Job 2529.3
4	2529.4	18 Nov 2015 11:54PM CUT	43	99.45	Travis Job 2529.4
5	2529.5	18 Nov 2015 11:54PM CUT	43	99.45	Travis Job 2529.5
6	2529.6	18 Nov 2015 11:54PM CUT	43	99.45	Travis Job 2529.6

Source Files on build 2529

Show entries

Search:

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
92.65	lib/router/layer.js	183 + 6	68 + 4	63 + 2	5 + 2	3473.0 - 62
95.45	examples/markdown/index.js	46	22	21	1	1.0
98.67	lib/router/route.js	211	75	74	1	1331.0 + 3
99.25	lib/router/index.js	646	265	263	2	976.0 + 1.0
99.71	lib/response.js	1054	342	341	1	80.0
100.0	examples/auth/index.js	131	57	57	0	3.0
100.0	examples/auth/pass.js	49	14	14	0	1.0
100.0	examples/content-negotiation/db.js	7	5	5	0	1.0
100.0	examples/content-negotiation/index.js	45	18	18	0	1.0
100.0	examples/content-negotiation/users.js	19	9	9	0	1.0
100.0	examples/cookie-sessions/index.js	28	12	12	0	1.0

Showing 1 to 10 of 43 entries

strongloop / express / 2529
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 2529

strongloop / express / 2529 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 2529

strongloop / express / 2529
100%

README BADGES
x